[PATCH] D61937: [llvm-readelf] - Rework how we parse the .dynamic section.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 20 23:34:01 PDT 2019


grimar added a comment.

In D61937#1505366 <https://reviews.llvm.org/D61937#1505366>, @jakehehrlich wrote:

> I have the same question as James with respect to requiring PT_DYNAMIC but otherwise the code looks good to me. I'm still looking at the tests.


I suddenly realized that forgot about this comment when committed. Sorry, Jake, if you have any post-commit review comments about the tests I'll be happy to address them.
(I am working on the follow-up patch for this, btw, which was suggested in this comment: https://reviews.llvm.org/D61937?id=199572#inline-552013. Some tests will be changed there.)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61937/new/

https://reviews.llvm.org/D61937





More information about the llvm-commits mailing list