[PATCH] D62172: [cmake] Add custom command to touch archives so ninja won't rebuild them.

Mon May 20 22:58:33 PDT 2019

hintonda added a comment.

In D62172#1509541 <https://reviews.llvm.org/D62172#1509541>, @beanz wrote:

> I have a long story about this issue... Ask me about it sometime :).
>
> We should get @thakis to weigh in here, but Ninja 1.8.2 works on Darwin because it uses the older filesystem APIs and ignores the high-precision timestamps. If we take this patch we should restrict it more. I suspect that libtool on Linux probably behaves correctly. Darwin's binutils fork is literally decades old.
>
> My guess at restricting the patch would be only on Darwin (which is the only place we use libtool), only if the Ninja version > 1.8.2, and Darwin version > 15.6.0 (I think 16.0.0 was when APFS went in which causes this issue).

That sound right.  I just did a quick check on a linux box and it didn't have the problem.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62172/new/

https://reviews.llvm.org/D62172