[PATCH] D62165: [MachinePipeliner][NFC] Add some debug log and statistics

Qing Shan Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 20 19:45:08 PDT 2019


steven.zhang accepted this revision.
steven.zhang added a comment.
This revision is now accepted and ready to land.

LGTM, except some minor comments.  However, please hold on for some days, if others have comments.



================
Comment at: llvm/lib/CodeGen/MachinePipeliner.cpp:450
+    LLVM_DEBUG(dbgs() << "MII > " << SwpMaxMii
+                      << " ,we don't pipleline large loops\n");
+    NumFailLargeMaxMII++;
----------------
The space should be after the comma instead of before it.


================
Comment at: llvm/lib/CodeGen/MachinePipeliner.cpp:492
+  if (!Scheduled){
+    LLVM_DEBUG(dbgs() << "No schedule found, return\n" );
+    NumFailNoSchedule++;
----------------
extra space. And 'Not scheduled' ?


================
Comment at: llvm/lib/CodeGen/MachinePipeliner.cpp:508
+    LLVM_DEBUG(dbgs() << "numStages:" << numStages << ">" << SwpMaxStages
+                      << " : Too many stages, abort\n");
+    NumFailLargeMaxStage++;
----------------
Too -> too


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62165/new/

https://reviews.llvm.org/D62165





More information about the llvm-commits mailing list