[PATCH] D61935: Fixes PPC64 Tbegin disassembling

Jinsong Ji via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 20 11:35:36 PDT 2019


jsji added a comment.

In D61935#1506244 <https://reviews.llvm.org/D61935#1506244>, @catenacyber wrote:

> Is this ok ?
>  Did I pick the right file ?
>  How do I run these tests ?


TBEGIN has `Predicates = [HasHTM]`, and `FeatureHTM` is `Power8SpecificFeatures`.
So it would be better to put these in a test file for P8 <https://reviews.llvm.org/P8> and above, with RUN line containing `-mcpu=pwr8`.

Unfortunately, both `ppc64-encoding-p8vector.txt` and `ppc64-encoding-p9vector.txt` are not suitable for this due to file naming,
so maybe you should create a file like `ppc64-encoding-p8htm.txt`.

`make check-llvm` should run all the tests including this file.
Alternatively, you can use llvm-lit to run it directly for debugging:
`llvm-lit llvm/test/MC/Disassembler/PowerPC/ppc64-encoding.txt`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61935/new/

https://reviews.llvm.org/D61935





More information about the llvm-commits mailing list