[PATCH] D62077: [InstSimplify] Teach fsub -0.0, (fneg X) ==> X about unary fneg

Phabricator via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 20 06:11:00 PDT 2019


This revision was automatically updated to reflect the committed changes.
Closed by commit rL361151: [InstSimplify] Teach fsub -0.0, (fneg X) ==> X about unary fneg (authored by mcinally, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D62077?vs=200086&id=200264#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62077/new/

https://reviews.llvm.org/D62077

Files:
  llvm/trunk/lib/Analysis/InstructionSimplify.cpp
  llvm/trunk/test/Transforms/InstSimplify/floating-point-arithmetic.ll


Index: llvm/trunk/test/Transforms/InstSimplify/floating-point-arithmetic.ll
===================================================================
--- llvm/trunk/test/Transforms/InstSimplify/floating-point-arithmetic.ll
+++ llvm/trunk/test/Transforms/InstSimplify/floating-point-arithmetic.ll
@@ -60,9 +60,7 @@
 ; fsub -0.0, (fneg X) ==> X
 define float @fneg_x(float %a) {
 ; CHECK-LABEL: @fneg_x(
-; CHECK-NEXT:    %t1 = fneg float %a
-; CHECK-NEXT:    %ret = fsub float -0.000000e+00, %t1
-; CHECK-NEXT:    ret float %ret
+; CHECK-NEXT:    ret float [[A:%.*]]
 ;
   %t1 = fneg float %a
   %ret = fsub float -0.0, %t1
@@ -80,9 +78,7 @@
 
 define <2 x float> @fneg_x_vec(<2 x float> %a) {
 ; CHECK-LABEL: @fneg_x_vec(
-; CHECK-NEXT:    %t1 = fneg <2 x float> %a
-; CHECK-NEXT:    %ret = fsub <2 x float> <float -0.000000e+00, float -0.000000e+00>, %t1
-; CHECK-NEXT:    ret <2 x float> %ret
+; CHECK-NEXT:    ret <2 x float> [[A:%.*]]
 ;
   %t1 = fneg <2 x float> %a
   %ret = fsub <2 x float> <float -0.0, float -0.0>, %t1
@@ -100,9 +96,7 @@
 
 define <2 x float> @fneg_x_vec_undef_elts(<2 x float> %a) {
 ; CHECK-LABEL: @fneg_x_vec_undef_elts(
-; CHECK-NEXT:    %t1 = fneg <2 x float> %a
-; CHECK-NEXT:    %ret = fsub <2 x float> <float -0.000000e+00, float undef>, %t1
-; CHECK-NEXT:    ret <2 x float> %ret
+; CHECK-NEXT:    ret <2 x float> [[A:%.*]]
 ;
   %t1 = fneg <2 x float> %a
   %ret = fsub <2 x float> <float -0.0, float undef>, %t1
Index: llvm/trunk/lib/Analysis/InstructionSimplify.cpp
===================================================================
--- llvm/trunk/lib/Analysis/InstructionSimplify.cpp
+++ llvm/trunk/lib/Analysis/InstructionSimplify.cpp
@@ -4404,9 +4404,10 @@
     return Op0;
 
   // fsub -0.0, (fsub -0.0, X) ==> X
+  // fsub -0.0, (fneg X) ==> X
   Value *X;
   if (match(Op0, m_NegZeroFP()) &&
-      match(Op1, m_FSub(m_NegZeroFP(), m_Value(X))))
+      match(Op1, m_FNeg(m_Value(X))))
     return X;
 
   // fsub 0.0, (fsub 0.0, X) ==> X if signed zeros are ignored.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62077.200264.patch
Type: text/x-patch
Size: 2006 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190520/486522af/attachment.bin>


More information about the llvm-commits mailing list