[PATCH] D62114: [Bugpoint] fix another use-after-move. NFC

Nick Desaulniers via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 19 18:50:09 PDT 2019


nickdesaulniers created this revision.
nickdesaulniers added reviewers: echristo, srhines.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This was flagged in https://www.viva64.com/en/b/0629/ under "Snippet No.
7".

These statements are order independent, short of the use-after-move.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D62114

Files:
  llvm/tools/bugpoint/Miscompilation.cpp


Index: llvm/tools/bugpoint/Miscompilation.cpp
===================================================================
--- llvm/tools/bugpoint/Miscompilation.cpp
+++ llvm/tools/bugpoint/Miscompilation.cpp
@@ -705,8 +705,8 @@
   if (!Optimized) {
     errs() << " Error running this sequence of passes"
            << " on the input program!\n";
-    BD.setNewProgram(std::move(Test));
     BD.EmitProgressBitcode(*Test, "pass-error", false);
+    BD.setNewProgram(std::move(Test));
     if (Error E = BD.debugOptimizerCrash())
       return std::move(E);
     return false;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62114.200194.patch
Type: text/x-patch
Size: 569 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190520/826eed5e/attachment.bin>


More information about the llvm-commits mailing list