[PATCH] D61492: AMDGPU: Prepare for explicit absolute relocations in code generation

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun May 19 09:00:17 PDT 2019


arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

LGTM with nit



================
Comment at: lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp:405-408
+    if (Kind == MCSymbolRefExpr::VK_AMDGPU_ABS32_LO ||
+        Kind == MCSymbolRefExpr::VK_AMDGPU_ABS32_HI)
+      return false;
     return true;
----------------
return Kind != lo && Kind != Hi


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61492/new/

https://reviews.llvm.org/D61492





More information about the llvm-commits mailing list