[PATCH] D62099: UpdateTestChecks: fix AMDGPU handling

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 18 05:48:28 PDT 2019


lebedev.ri marked an inline comment as done.
lebedev.ri added inline comments.


================
Comment at: utils/UpdateTestChecks/asm.py:205
+  triples = {
+      'amdgcn': 'amdgcn',
+  }
----------------
arsenm wrote:
> Why this hardcoded list?
I'm not sure how to answer that.
Because this is the pattern that will allow to most easily add new entries, should that be needed.
I'm not sure how else to acquire this mapping.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62099/new/

https://reviews.llvm.org/D62099





More information about the llvm-commits mailing list