[PATCH] D61996: [llvm-objdump]Improve testing of some switches #2

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat May 18 03:17:18 PDT 2019


MaskRay added inline comments.


================
Comment at: test/tools/llvm-objdump/X86/Inputs/source-interleave.ll:2
+; ModuleID = 'source-interleave-x86_64.bc'
+source_filename = "source-interleave-x86_64.c"
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
----------------
Rename..


================
Comment at: test/tools/llvm-objdump/X86/source-interleave-missing-source.test:5
+# RUN: sed -e "s,SRC_COMPDIR,%t,g" %p/Inputs/source-interleave.ll > %t.ll
+# RUN: sed -e "s,SRC_COMPDIR,%/p/Inputs,g" %p/Inputs/source-interleave.ll > %t2.ll
+
----------------
I wanted to ask whether `sed -e 's,SRC_COMPDIR,%p,'` works on Windows, if it works, we don't need to use `%/p`.

In a *nix shell, `printf %s '\a\b'` => `\a\b`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61996/new/

https://reviews.llvm.org/D61996





More information about the llvm-commits mailing list