[PATCH] D62084: Fix DWARF DebugInfo unit test errors when cross-compiling

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 17 14:31:19 PDT 2019


daltenty created this revision.
daltenty added reviewers: hubert.reinterpretcast, sfertile, jasonliu.
daltenty added a project: LLVM.
Herald added subscribers: llvm-commits, jsji, aprantl.

When building with a Default Target set we can experience issues in the DWARF DebugInfo unit tests because:

- They assume we can generate object files for the host platform
- Some tests assume the endianess of the target we are generating DWARF for and the host match

This patch correct these issues by ensuring the tests which generate objects in memory are run with respect to LVM_DEFAULT_TARGET_TRIPLE and it's
endianess. We also make sure we don't use the hosts address size for line test and split the triple util function in DwarfUtils into a version that takes an address size and one that doesn't.

See also for discussion: http://lists.llvm.org/pipermail/llvm-dev/2019-March/131212.html


Repository:
  rL LLVM

https://reviews.llvm.org/D62084

Files:
  llvm/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp
  llvm/unittests/DebugInfo/DWARF/DWARFDebugLineTest.cpp
  llvm/unittests/DebugInfo/DWARF/DwarfUtils.cpp
  llvm/unittests/DebugInfo/DWARF/DwarfUtils.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62084.200097.patch
Type: text/x-patch
Size: 6201 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190517/b8fdf053/attachment.bin>


More information about the llvm-commits mailing list