[PATCH] D61870: Make cl::HideUnrelatedOptionsless error-prone

[Don Hinton via Phabricator via llvm-commits]

hintonda requested changes to this revision.
hintonda added a comment.
This revision now requires changes to proceed.

Btw, TopLevelSubCommand can't actually see every option, just those not specifically assigned to another SubCommand.  Typically, that only happens in applications, so this should work okay.  However, it would probably be safer to iterate over all SubCommands instead of just looking TopLevelSubCommand.  Though I'm not sure that really matters.

While I can't conceive of any reason I'd want to pass a SubCommand, it would be better to come up with a motivating example of how you plan to use this before we make any changes, since specific use-cases might require a slightly different implementation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61870/new/

https://reviews.llvm.org/D61870