[PATCH] D62025: Expand llvm.is.constant earlier

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 17 13:54:35 PDT 2019


lebedev.ri added a comment.

2c:
Is it guaranteed that this transform (instsimplify) will *ONLY* *EVER* run once at the end of the pipeline?
*Every* pipeline ever created? That is the 'requirement' on this `@llvm.is.constant` expansion, i believe.
Would it not be better to not rely on this implicit, undocumented, untested behavior?

Regardless of that, this is missing tests in instsimplify directory.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62025/new/

https://reviews.llvm.org/D62025





More information about the llvm-commits mailing list