[PATCH] D61745: [scudo][standalone] Introduce the Primary(s) and LocalCache

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 17 10:37:57 PDT 2019


cryptoad added inline comments.


================
Comment at: lib/scudo/standalone/local_cache.h:152
+    TransferBatch *B = Allocator->popBatch(this, ClassId);
+    DCHECK_GT(B->getCount(), 0);
+    B->copyToArray(C->Chunks);
----------------
cryptoad wrote:
> morehouse wrote:
> > What if `B == nullptr`?
> Batch creation failure is fatal, I'll add a CHECK.
Nevermind it has to return false!


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61745/new/

https://reviews.llvm.org/D61745





More information about the llvm-commits mailing list