[PATCH] D62067: [Support] Time profiler: support new PassManager

Anton Afanasyev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 17 08:55:59 PDT 2019


anton-afanasyev added a comment.

In D62067#1506690 <https://reviews.llvm.org/D62067#1506690>, @lebedev.ri wrote:

> I know this is in line with what is done in old-pm, but i find the middle-end names to be very useless.
>  In particular, why is the actual optimization pass name is always in the description, and the actual timeslice name is always the same generic "Opt???"?
>  IMHO the actual optimization pass name should be the Name, not Detail.


We can change this in a separate commits in both new and old pm.
Same name "Opt???" makes the same color in a flamechart. Btw, have you tried Speedscope (https://www.speedscope.app) for visualization? It works better than chrome://tracing, trying to show details in chart boxes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62067/new/

https://reviews.llvm.org/D62067





More information about the llvm-commits mailing list