[PATCH] D62000: [AArch64][SVE2] Asm: add int halving add/sub (predicated) instructions

Diana Picus via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 17 01:35:33 PDT 2019


rovka accepted this revision.
rovka added a comment.
This revision is now accepted and ready to land.

LGTM but I have one question :)



================
Comment at: test/MC/AArch64/SVE2/shadd-diagnostics.s:32
+// CHECK-NEXT: shadd z0.b, p8/m, z0.b, z1.b
+// CHECK-NOT: [[@LINE-1]]:{{[0-9]+}}:
----------------
Should we also test that <Pg>/z errors out?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62000/new/

https://reviews.llvm.org/D62000





More information about the llvm-commits mailing list