[PATCH] D61898: Move symbol resolution code out of SymbolTable class.
Rui Ueyama via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu May 16 18:50:16 PDT 2019
ruiu marked 2 inline comments as done.
ruiu added inline comments.
================
Comment at: lld/ELF/SymbolTable.cpp:605
+ case Symbol::PlaceholderKind:
+ llvm_unreachable("bad symbol type");
+ }
----------------
MaskRay wrote:
> symbol kind?
Done
================
Comment at: lld/ELF/Symbols.h:449
+
+inline void replaceSymbol(Symbol *Sym, const Symbol *New) {
+ using llvm::ELF::STT_TLS;
----------------
MaskRay wrote:
> Does `const Symbol &New` work? Other add* functions use const references, e.g.
>
> `static void addShared(Symbol *Old, const SharedSymbol &New) {`
Done.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61898/new/
https://reviews.llvm.org/D61898
More information about the llvm-commits
mailing list