[PATCH] D62033: Change llvm_add_library to always use name for static libraries

[Wink Saville via Phabricator via llvm-commits]

winksaville added a comment.

In D62033#1505748 <https://reviews.llvm.org/D62033#1505748>, @beanz wrote:

> I don't know that we want to support building component libraries as both `STATIC` and `SHARED` except in very specific and limited situations.
>
> We actually don't seem to use this functionality in-tree anywhere, so I'm more inclined to turn this into an error than to fix it.


I too had looked and found no place where it was used.  But it does automatically use OBJECT so if and when it is used
".o's" aren't built twice. I suspect there are currently places in the build system which build both and don't use OBJECT
and thus are taking more time and space than necessary. So I'd vote to keep the capability, but if not then your suggestion
of turning it into an error is also a solution.

If turning this into an error is what you want to do I can prepare a patch, or you can do it, your choice.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62033/new/

https://reviews.llvm.org/D62033