[PATCH] D61991: [WebAssembly] Don't generate empty type section.

[Phabricator via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rL360940: [WebAssembly] Don't generate empty type sections. (authored by sbc, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D61991?vs=199748&id=199904#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61991/new/

https://reviews.llvm.org/D61991

Files:
  lld/trunk/test/wasm/section-symbol-relocs.yaml
  lld/trunk/wasm/Writer.cpp


Index: lld/trunk/test/wasm/section-symbol-relocs.yaml
===================================================================
--- lld/trunk/test/wasm/section-symbol-relocs.yaml
+++ lld/trunk/test/wasm/section-symbol-relocs.yaml
@@ -49,3 +49,13 @@
 # RELOC-NEXT:         Offset:          0x0000000B
 # RELOC-NEXT:         Addend:          3
 # RELOC-NEXT:    Name:            green
+#
+# RELOC:        SymbolTable:
+# RELOC-NEXT:     - Index:           0
+# RELOC-NEXT:       Kind:            SECTION
+# RELOC-NEXT:       Flags:           [ BINDING_LOCAL ]
+# RELOC-NEXT:       Section:         2
+# RELOC-NEXT:     - Index:           1
+# RELOC-NEXT:       Kind:            SECTION
+# RELOC-NEXT:       Flags:           [ BINDING_LOCAL ]
+# RELOC-NEXT:       Section:         3
Index: lld/trunk/wasm/Writer.cpp
===================================================================
--- lld/trunk/wasm/Writer.cpp
+++ lld/trunk/wasm/Writer.cpp
@@ -234,6 +234,8 @@
 }
 
 void Writer::createTypeSection() {
+  if (!Types.size())
+    return;
   SyntheticSection *Section = createSyntheticSection(WASM_SEC_TYPE);
   raw_ostream &OS = Section->getStream();
   writeUleb128(OS, Types.size(), "type count");


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61991.199904.patch
Type: text/x-patch
Size: 1193 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190516/9a982e1a/attachment.bin>