[PATCH] D61756: Add a __FILE_NAME__ macro.

Don Hinton via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 16 08:52:44 PDT 2019


hintonda added a comment.

In D61756#1504109 <https://reviews.llvm.org/D61756#1504109>, @kristina wrote:

> Reverted in rL360842 <https://reviews.llvm.org/rL360842> as Windows bots were failing.
>
> I suspect the `MSVCCompat` case may need to be handled differently depending on the host OS similar to `PPDirectives.cpp`:
>
>     if (LangOpts.MSVCCompat) {
>       NormalizedPath = Filename.str();
>   #ifndef _WIN32
>       llvm::sys::path::native(NormalizedPath);
>   #endif
>     }
>
>
> Reopening this for now, will try to get a local Windows builder set up and work out what the problem is before relanding.


Can't you just always use `llvm::sys::path::filename(PLFileName)`?  It defaults to the native style.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61756/new/

https://reviews.llvm.org/D61756





More information about the llvm-commits mailing list