[PATCH] D61437: [AArch64] Static (de)allocation of SVE stack objects.

[Sander de Smalen via Phabricator via llvm-commits]

sdesmalen added a comment.

In D61437#1501444 <https://reviews.llvm.org/D61437#1501444>, @thegameg wrote:

> This sounds like it will report the wrong stack size in PEI for the StackSize remark and the stack size warning. Is that expected?


For now the answer is yes. One of our primary concerns at the moment is adding basic SVE spill/fill support and we appreciate the caveat that nothing in LLVM really supports the concept of scalable types yet, including offsets and sizes.

Patch D61435 <https://reviews.llvm.org/D61435> introduces (AArch64)StackOffset, which we'll use to describe offsets composed of a scalable and fixed-size part. Instead of recording sizes and offsets as an 'int' or 'unsigned', they should be described as an instance of a StackOffset/StackSize class. When the scalable-type patch (D32530 <https://reviews.llvm.org/D32530>) lands we should make an effort to roll out the StackOffset class (perhaps with an alias for StackSize) to generic CodeGen interfaces such as `getStackSize()`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61437/new/

https://reviews.llvm.org/D61437