[PATCH] D62004: [LLD] [MinGW] Allow requesting PDB output without giving a file name

[David Major via Phabricator via llvm-commits]

dmajor added inline comments.


================
Comment at: MinGW/Driver.cpp:168
     Add("-debug");
-    Add("-pdb:" + StringRef(A->getValue()));
+    StringRef V = StringRef(A->getValue());
+    if (!V.empty())
----------------
Is the `StringRef` on the RHS necessary?


================
Comment at: MinGW/Options.td:61
 def pdb: S<"pdb">, HelpText<"Specify output PDB debug information file">;
+def pdb_eq: J<"pdb=">, Alias<pdb>;
 def Xlink : J<"Xlink=">, MetaVarName<"<arg>">,
----------------
Should the new behavior be advertised in the HelpText or a doc somewhere?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62004/new/

https://reviews.llvm.org/D62004