[PATCH] D61941: [llvm-objdump]Improve testing of some switches #1

Thu May 16 01:30:58 PDT 2019

grimar added a comment.

I only have a minor comment (inlined).

Out of curiosity are you doing some code coverage check on the llvm-objdump to find the places uncovered?
Asking because I did that few times for LLD and this gave interesting results that time (IMO). I added many test cases and found few interesting bugs and a dead code pieces.
(i.e. if not - I can try to do that and share the results).

================
Comment at: test/tools/llvm-objdump/section-filter.test:222
+# NO-SECTION-NOT: .bss
+# NO-SECTION-NOT: foobar
----------------
Will it be better/simpler just to check no output explicitly?
i.e. something like

```
# NO-SECTION: Sections:
# NO-SECTION-NOT: {{.*}}
```

(not sure this is valid, but shows the idea)

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61941/new/

https://reviews.llvm.org/D61941