[llvm] r360857 - [IRMover] Improve diagnostic messages for conflicting metadata

[Igor Kudrin via llvm-commits]

Author: ikudrin
Date: Wed May 15 22:23:13 2019
New Revision: 360857

URL: http://llvm.org/viewvc/llvm-project?rev=360857&view=rev
Log:
[IRMover] Improve diagnostic messages for conflicting metadata

This does the similar for error messages as rL344011 has done for warnings.

With llvm::lto::LTO, the error might appear when LTO::run() is executed.
In that case, the calling code cannot know which module causes the error
and, subsequently, cannot hint the user.

Differential Revision: https://reviews.llvm.org/D61880

Modified:
    llvm/trunk/lib/Linker/IRMover.cpp
    llvm/trunk/test/Linker/module-flags-5-a.ll
    llvm/trunk/test/Linker/module-flags-6-a.ll
    llvm/trunk/test/Linker/module-flags-7-a.ll

Modified: llvm/trunk/lib/Linker/IRMover.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Linker/IRMover.cpp?rev=360857&r1=360856&r2=360857&view=diff
==============================================================================
--- llvm/trunk/lib/Linker/IRMover.cpp (original)
+++ llvm/trunk/lib/Linker/IRMover.cpp Wed May 15 22:23:13 2019
@@ -1223,7 +1223,9 @@ Error IRLinker::linkModuleFlagsMetadata(
       if (SrcBehaviorValue == Module::Override &&
           SrcOp->getOperand(2) != DstOp->getOperand(2))
         return stringErr("linking module flags '" + ID->getString() +
-                         "': IDs have conflicting override values");
+                         "': IDs have conflicting override values in '" +
+                         SrcM->getModuleIdentifier() + "' and '" +
+                         DstM.getModuleIdentifier() + "'");
       continue;
     } else if (SrcBehaviorValue == Module::Override) {
       // Update the destination flag to that of the source.
@@ -1234,7 +1236,9 @@ Error IRLinker::linkModuleFlagsMetadata(
     // Diagnose inconsistent merge behavior types.
     if (SrcBehaviorValue != DstBehaviorValue)
       return stringErr("linking module flags '" + ID->getString() +
-                       "': IDs have conflicting behaviors");
+                       "': IDs have conflicting behaviors in '" +
+                       SrcM->getModuleIdentifier() + "' and '" +
+                       DstM.getModuleIdentifier() + "'");
 
     auto replaceDstValue = [&](MDNode *New) {
       Metadata *FlagOps[] = {DstOp->getOperand(0), ID, New};
@@ -1252,7 +1256,9 @@ Error IRLinker::linkModuleFlagsMetadata(
       // Emit an error if the values differ.
       if (SrcOp->getOperand(2) != DstOp->getOperand(2))
         return stringErr("linking module flags '" + ID->getString() +
-                         "': IDs have conflicting values");
+                         "': IDs have conflicting values in '" +
+                         SrcM->getModuleIdentifier() + "' and '" +
+                         DstM.getModuleIdentifier() + "'");
       continue;
     }
     case Module::Warning: {

Modified: llvm/trunk/test/Linker/module-flags-5-a.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Linker/module-flags-5-a.ll?rev=360857&r1=360856&r2=360857&view=diff
==============================================================================
--- llvm/trunk/test/Linker/module-flags-5-a.ll (original)
+++ llvm/trunk/test/Linker/module-flags-5-a.ll Wed May 15 22:23:13 2019
@@ -2,7 +2,7 @@
 
 ; Test the 'override' error.
 
-; CHECK: linking module flags 'foo': IDs have conflicting override values
+; CHECK: linking module flags 'foo': IDs have conflicting override values in '{{.*}}module-flags-5-b.ll' and 'llvm-link'
 
 !0 = !{ i32 4, !"foo", i32 927 }
 

Modified: llvm/trunk/test/Linker/module-flags-6-a.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Linker/module-flags-6-a.ll?rev=360857&r1=360856&r2=360857&view=diff
==============================================================================
--- llvm/trunk/test/Linker/module-flags-6-a.ll (original)
+++ llvm/trunk/test/Linker/module-flags-6-a.ll Wed May 15 22:23:13 2019
@@ -2,7 +2,7 @@
 
 ; Test module flags error messages.
 
-; CHECK: linking module flags 'foo': IDs have conflicting values
+; CHECK: linking module flags 'foo': IDs have conflicting values in '{{.*}}module-flags-6-b.ll' and 'llvm-link'
 
 !0 = !{ i32 1, !"foo", i32 37 }
 

Modified: llvm/trunk/test/Linker/module-flags-7-a.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Linker/module-flags-7-a.ll?rev=360857&r1=360856&r2=360857&view=diff
==============================================================================
--- llvm/trunk/test/Linker/module-flags-7-a.ll (original)
+++ llvm/trunk/test/Linker/module-flags-7-a.ll Wed May 15 22:23:13 2019
@@ -2,7 +2,7 @@
 
 ; Test module flags error messages.
 
-; CHECK: linking module flags 'foo': IDs have conflicting behaviors
+; CHECK: linking module flags 'foo': IDs have conflicting behaviors in '{{.*}}module-flags-7-b.ll' and 'llvm-link'
 
 !0 = !{ i32 1, !"foo", i32 37 }