[PATCH] D61881: Deal with return-twice function such as vfork, setjmp when CET-IBT enabled

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 15 21:40:48 PDT 2019


craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86IndirectBranchTracking.cpp:144
+      if (IsCallReturnTwice(I->getOperand(0)))
+        Changed |= addENDBR(MBB, I);
+    }
----------------
What if we passed I++ here and passed MBB.begin() on the other callsites. Could we then avoid two different cases in addENDBR?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61881/new/

https://reviews.llvm.org/D61881





More information about the llvm-commits mailing list