[llvm] r360807 - Add unary fneg to InstSimplify/fp-nan.ll

Wed May 15 13:45:55 PDT 2019

On Wed, May 15, 2019 at 11:43 PM Cameron McInally
<cameron.mcinally at nyu.edu> wrote:
>
> Sure, no problem.
>
> I was trying to stay within the git 80 char summary limit. Is that not a problem? Or should the details go in the body?
That is kinda the point.
The subject should be as informative as possible. ~80 chars is a lot of space.

> On Wed, May 15, 2019 at 4:32 PM Roman Lebedev <lebedev.ri at gmail.com> wrote:
>>
>> Really minor, but could your commit messages please
>> follow the general pattern of other commit messages?
>> In particular, this could have been
>> "[NFC][InstSimplify] Add more unary fneg tests to fp-nan.ll"
>>
>> Roman.
>>
>> On Wed, May 15, 2019 at 11:24 PM Cameron McInally via llvm-commits
>> <llvm-commits at lists.llvm.org> wrote:
>> >
>> > Author: mcinally
>> > Date: Wed May 15 13:27:35 2019
>> > New Revision: 360807
>> >
>> > URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject-3Frev-3D360807-26view-3Drev&d=DwIBaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=YzI3EnjdxSNx535S0MftkJS_JgIWIFnV_C6uMmH4-Wk&s=riimpdhdq754Tsd8qcD-Ws5E6vTKN1MfzkMDYb7MmUc&e=
>> > Log:
>> > Add unary fneg to InstSimplify/fp-nan.ll
>> >
>> > Modified:
>> >     llvm/trunk/test/Transforms/InstSimplify/fp-nan.ll
>> >
>> > Modified: llvm/trunk/test/Transforms/InstSimplify/fp-nan.ll
>> > URL: https://urldefense.proofpoint.com/v2/url?u=http-3A__llvm.org_viewvc_llvm-2Dproject_llvm_trunk_test_Transforms_InstSimplify_fp-2Dnan.ll-3Frev-3D360807-26r1-3D360806-26r2-3D360807-26view-3Ddiff&d=DwIBaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=YzI3EnjdxSNx535S0MftkJS_JgIWIFnV_C6uMmH4-Wk&s=LkGwPjFdB5neBd-AqFmN_qveGBZKTqE6Zmr8J9X8F6c&e=
>> > ==============================================================================
>> > --- llvm/trunk/test/Transforms/InstSimplify/fp-nan.ll (original)
>> > +++ llvm/trunk/test/Transforms/InstSimplify/fp-nan.ll Wed May 15 13:27:35 2019
>> > @@ -117,6 +117,14 @@ define double @unary_fneg_nan_1(double %
>> >    ret double %r
>> >  }
>> >
>> > +define double @unary_fneg_nan_1(double %x) {
>> > +; CHECK-LABEL: @unary_fneg_nan_1(
>> > +; CHECK-NEXT:    ret double 0xFFFABCDEF0123456
>> > +;
>> > +  %r = fneg double 0x7FFABCDEF0123456
>> > +  ret double %r
>> > +}
>> > +
>> >  define <2 x double> @fneg_nan_2(<2 x double> %x) {
>> >  ; CHECK-LABEL: @fneg_nan_2(
>> >  ; CHECK-NEXT:    ret <2 x double> <double 0x7FF1234567890ABC, double 0xFFF0000000000001>
>> > @@ -125,6 +133,14 @@ define <2 x double> @fneg_nan_2(<2 x dou
>> >    ret <2 x double> %r
>> >  }
>> >
>> > +define <2 x double> @unary_fneg_nan_2(<2 x double> %x) {
>> > +; CHECK-LABEL: @unary_fneg_nan_2(
>> > +; CHECK-NEXT:    ret <2 x double> <double 0x7FF1234567890ABC, double 0xFFF0000000000001>
>> > +;
>> > +  %r = fneg <2 x double> <double 0xFFF1234567890ABC, double 0x7FF0000000000001>
>> > +  ret <2 x double> %r
>> > +}
>> > +
>> >  define <2 x double> @unary_fneg_nan_2(<2 x double> %x) {
>> >  ; CHECK-LABEL: @unary_fneg_nan_2(
>> >  ; CHECK-NEXT:    ret <2 x double> <double 0x7FF1234567890ABC, double 0xFFF0000000000001>
>> >
>> >
>> > _______________________________________________
>> > llvm-commits mailing list
>> > llvm-commits at lists.llvm.org
>> > https://urldefense.proofpoint.com/v2/url?u=https-3A__lists.llvm.org_cgi-2Dbin_mailman_listinfo_llvm-2Dcommits&d=DwIBaQ&c=slrrB7dE8n7gBJbeO0g-IQ&r=O_4M49EtSpZ_-BQYeigzGv0P4__noMcSu2RYEjS1vKs&m=YzI3EnjdxSNx535S0MftkJS_JgIWIFnV_C6uMmH4-Wk&s=A_3slit-SN0bIIajmAr4ccZZpDb_zU1Zj142Nr6orBE&e=