[PATCH] D61154: [PredicateInfo] Do not process unreachable operands.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 15 11:59:40 PDT 2019


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM with one minor comment.



================
Comment at: llvm/lib/Transforms/Utils/PredicateInfo.cpp:476
     if (auto *II = dyn_cast_or_null<IntrinsicInst>(Assume))
-      processAssume(II, II->getParent(), OpsToRename);
+      if (DT.getNode(II->getParent()))
+        processAssume(II, II->getParent(), OpsToRename);
----------------
It would be more clear to use isReachableFromEntry (which does the same thing, but it has a better name).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61154/new/

https://reviews.llvm.org/D61154





More information about the llvm-commits mailing list