[PATCH] D60565: [LOOPINFO] Extend Loop object to add utilities to get the loop bounds, step, induction variable, and guard branch.

Whitney via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed May 15 11:57:43 PDT 2019


Whitney added inline comments.


================
Comment at: llvm/unittests/Analysis/LoopInfoTest.cpp:752
+      });
+}
----------------
kbarton wrote:
> These tests look good. I don't see any tests for the following - could you add some:
> 
> 1. Loop Bounds and associated methods you have added
> 2. Unguarded loops (i.e., loops with constant upper bounds should not get a guard).
> 3. Loop nests
> 4. Functions with control flow that do not "guard" the loop.
> 
Added more test cases


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60565/new/

https://reviews.llvm.org/D60565





More information about the llvm-commits mailing list