[PATCH] D61870: Make cl::HideUnrelatedOptions more flexible

[Chris Bieneman via Phabricator via llvm-commits]

beanz added a comment.

This patch doesn't actually include how the new code will be used, and the review doesn't include enough context for me to understand what is going on.

Since this seems to be motivated by the `llvm-cat` option situation, which I believe is caused when using `LLVM_LINK_LLVM_DYLIB`, I expect that we will want to use `cl::HideUnrelatedOptions` in a lot more places to clean up other tool help messages. That makes me a little more concerned about the API and not having a clear picture of the use cases I'm not sure this is correct.

In particular I think the common case may be setting `cl::ReallyHidden` (I see no example otherwise), which means as soon as we start applying this tool to tools with subcommands the API gets messy.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61870/new/

https://reviews.llvm.org/D61870