[PATCH] D60386: FileCheck [6/12]: Introduce numeric variable definition

[Thomas Preud'homme via Phabricator via llvm-commits]

thopre added inline comments.


================
Comment at: llvm/include/llvm/Support/FileCheck.h:145
 public:
-  /// Constructor for a pattern variable substitution.
+  /// Constructor for a pattern substitution.
   FileCheckPatternSubstitution(FileCheckPatternContext *Context,
----------------
jhenderson wrote:
> I'm not sure I understand why these comments have changed?
Prior to this patch, the only thing [[#<something>]] block could contain was a numeric expression to substitute by its value when matching. It can now contain a numeric variable definition which needs to be substituted for a suitable wildcard expression ([0-9]+), in which case there is no numeric expression. I therefore thought the name "numeric expression substitution" was inappropriate and decided to change it to "numeric substitution". While patterns variable are never involved in expression, for consistency I've decided to also rename pattern variable substitution into pattern substitution.

I think there was also some inconsistency (perhaps in later patches in the series) where [[#<something>]] used to be referred to as numeric expression, now there is a separate name for this and the numeric expression part of a numeric substitution.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60386/new/

https://reviews.llvm.org/D60386