[PATCH] D61532: implement of the parsing symbol table for xcoffobjfile and output as yaml format

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast requested changes to this revision.
hubert.reinterpretcast added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:170
+
+  // Note that return value is signed and might return a negative value.
+  // Negative values are reserved for future use.
----------------
DiggerLin wrote:
> sfertile wrote:
> > I would suggest rewording this, maybe
> > `// The value as encoded in the object file.`
> > 
> > I think that + the following line is enough to convey negative values *are* allowed/expected.
> changed comment as suggestion
s/Note that return/Returns/;


================
Comment at: llvm/include/llvm/Object/XCOFFObjectFile.h:174
+	
+  // Note that return value is unsigned,a negative value will return as zero.
+  uint32_t getLogicalNumberOfSymbolTableEntries() const;
----------------
DiggerLin wrote:
> sfertile wrote:
> > maybe: `// Sanitized value, useable as an index into the symbol table.` instead.
> fixed
s/Return/Returns a/;


================
Comment at: llvm/tools/obj2yaml/xcoff2yaml.cpp:64
+
+    Sym.Value = SymbolEntPtr->Value;
+
----------------
Length mismatch.
```
llvm::yaml::Hex16 Value; // Symbol value; storage class-dependent.
```
```
support::ubig32_t Value; // Symbol value; storage class-dependent.
```



Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61532/new/

https://reviews.llvm.org/D61532