[PATCH] D61791: Replace lit feature keyword 'non_COFF' with 'uses_COFF'.

Paul Robinson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 14 07:50:09 PDT 2019


This revision was not accepted when it landed; it landed in state "Needs Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit rL360680: Replace lit feature keyword 'not_COFF' with 'uses_COFF'. (authored by probinson, committed by ).

Changed prior to commit:
  https://reviews.llvm.org/D61791?vs=199025&id=199444#toc

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61791/new/

https://reviews.llvm.org/D61791

Files:
  llvm/trunk/test/ExecutionEngine/MCJIT/weak-function.ll
  llvm/trunk/test/ExecutionEngine/OrcMCJIT/weak-function.ll
  llvm/trunk/test/lit.cfg.py


Index: llvm/trunk/test/ExecutionEngine/OrcMCJIT/weak-function.ll
===================================================================
--- llvm/trunk/test/ExecutionEngine/OrcMCJIT/weak-function.ll
+++ llvm/trunk/test/ExecutionEngine/OrcMCJIT/weak-function.ll
@@ -1,5 +1,5 @@
 ; RUN: lli -jit-kind=orc-mcjit -extra-module %p/Inputs/weak-function-2.ll %s
-; REQUIRES: not_COFF
+; UNSUPPORTED: uses_COFF
 ;
 ; Check that functions in two different modules agree on the address of weak
 ; function 'baz'.
Index: llvm/trunk/test/ExecutionEngine/MCJIT/weak-function.ll
===================================================================
--- llvm/trunk/test/ExecutionEngine/MCJIT/weak-function.ll
+++ llvm/trunk/test/ExecutionEngine/MCJIT/weak-function.ll
@@ -1,5 +1,5 @@
 ; RUN: lli -jit-kind=mcjit -extra-module %p/Inputs/weak-function-2.ll %s
-; REQUIRES: not_COFF
+; UNSUPPORTED: uses_COFF
 ;
 ; Check that functions in two different modules agree on the address of weak
 ; function 'baz'
Index: llvm/trunk/test/lit.cfg.py
===================================================================
--- llvm/trunk/test/lit.cfg.py
+++ llvm/trunk/test/lit.cfg.py
@@ -179,10 +179,12 @@
 
 config.available_features.add("host-byteorder-" + sys.byteorder + "-endian")
 
-# Others/can-execute.txt
-if sys.platform not in ['win32']:
+if sys.platform in ['win32']:
+    # ExecutionEngine, no weak symbols in COFF.
+    config.available_features.add('uses_COFF')
+else:
+    # Others/can-execute.txt
     config.available_features.add('can-execute')
-    config.available_features.add('not_COFF')
 
 # Loadable module
 # FIXME: This should be supplied by Makefile or autoconf.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D61791.199444.patch
Type: text/x-patch
Size: 1655 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190514/a02fcb5d/attachment.bin>


More information about the llvm-commits mailing list