[PATCH] D61891: DWARF v5: emit DW_AT_addr_base if DW_AT_low_pc references .debug_addr

[Paul Robinson via Phabricator via llvm-commits]

probinson accepted this revision.
probinson added a comment.
This revision is now accepted and ready to land.

LGTM once you rephrase the comment in the test.



================
Comment at: test/DebugInfo/Generic/line-table-addrx.ll:3
+
+;; We used to omit DW_AT_addr_base for LineTablesOnly in DWARF v5.
+; CHECK: DW_AT_low_pc [DW_FORM_addrx]
----------------
Comments should describe things as they exist with the patch, not how things used to be.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61891/new/

https://reviews.llvm.org/D61891