[PATCH] D61150: [SimplifyCFG] NFC, update Switch tests to HEAD so I can see if my changes change anything

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue May 14 00:33:37 PDT 2019


nikic added inline comments.


================
Comment at: test/Transforms/SimplifyCFG/switch-on-const-select.ll:158
 
 ; CHECK: attributes [[$NUW]] = { nounwind }
 ; CHECK: attributes #1 = { cold noreturn nounwind }
----------------
shawnl wrote:
> nikic wrote:
> > Does this test actually pass after being regenerated? I'd expect an error due to the undefined variable here. This probably needs to be replaced with just `#0` if you're using it above.
> You are referring to the other file, but yes it fails, but no, this is not a bug in LLVM, but rather a bug in the test.
I'm referring to the use of `[[$NUW]]` here, even though the corresponding `[[$NUW:#[0-9]+]]` above has been removed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61150/new/

https://reviews.llvm.org/D61150





More information about the llvm-commits mailing list