[PATCH] D61881: Deal with return-twice function such as vfork, setjmp when CET-IBT enabled

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: lib/Target/X86/X86IndirectBranchTracking.cpp:73
+bool X86IndirectBranchTrackingPass::addENDBR(MachineBasicBlock &MBB,
+                                          MachineBasicBlock::iterator I) const {
   assert(TII && "Target instruction info was not initialized");
----------------
indent with clang-format.


================
Comment at: lib/Target/X86/X86IndirectBranchTracking.cpp:79
+    if (EndbrOpcode != I->getOpcode()) {
+      I++;
+      BuildMI(MBB, I, MBB.findDebugLoc(I), TII->get(EndbrOpcode));
----------------
`++I;`


================
Comment at: lib/Target/X86/X86IndirectBranchTracking.cpp:140
+
+    for (MachineBasicBlock::iterator I = MBB.begin(), E = MBB.end();
+         I != E; ++I) {
----------------
`for (const MachineInstr &MI : MBB)`


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61881/new/

https://reviews.llvm.org/D61881