[PATCH] D61821: gn build: add RISCV target

[David L. Jones via Phabricator via llvm-commits]

dlj added inline comments.


================
Comment at: llvm/utils/gn/secondary/llvm/lib/Target/RISCV/BUILD.gn:30
+    ":LLVMRISCVCodeGen",
+    "Utils",
+  ]
----------------
thakis wrote:
> I think this is the first target that has Utils depending on the higher-up tablegen target. What is this needed for?
Oh, you're completely right... it should go in the public_deps of Utils. (Now I see what you mean... that's what AArch64 does, too.)


================
Comment at: llvm/utils/gn/secondary/llvm/lib/Target/targets.gni:26
     "Hexagon",
     "Lanai",
----------------
thakis wrote:
> (pass `-U9999` to git diff when generating diffs, so that phab doesn't have to say "Context not available.")
Oops, sorry about that...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61821/new/

https://reviews.llvm.org/D61821