[PATCH] D61082: llvm-nm and llvm-objcopy belong to toolchain

Alexander Shaposhnikov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 13 17:09:39 PDT 2019


alexshap added a comment.

1. patches which are meant to be sent for code review should include "full context" https://llvm.org/docs/Phabricator.html
2. I think it'd be useful to flash out the description of this change (why you are changing this / what does this fix, even if the change is small)

my understanding is that you are trying to change LLVM_TOOLCHAIN_TOOLS  - is it correct ?

3. I will add one more reviewer to have a look at this diff (just in case).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61082/new/

https://reviews.llvm.org/D61082





More information about the llvm-commits mailing list