[PATCH] D61863: [X86] Prefer locked stack op over mfence for seq_cst 64-bit stores on 32-bit targets

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 13 11:56:39 PDT 2019


craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM to me with one minor



================
Comment at: lib/Target/X86/X86ISelLowering.cpp:26427
+      // If this is a sequentially consistent store, also emit an appropriate
+      // barrier 
       if (IsSeqCst)
----------------
Add a period to the end of this comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61863/new/

https://reviews.llvm.org/D61863





More information about the llvm-commits mailing list