[Diffusion] rL360444: [LSR] Tweak setup cost depth threshold to 10.

[Amara Emerson via Phabricator via llvm-commits]

aemerson added a comment.

Fair enough, I've reverted this in r360589. The test case seemed cumbersome to reduce and commit just for a threshold change, but I'm not sure what the best approach is here yet beyond a depth limit change.

As for rdar, that's been accepted in LLVM for a long time in commit messages, as long as they're not in code comments.

In rL360444#648889 <https://reviews.llvm.org/rL360444#648889>, @SjoerdMeijer wrote:

> We are changing one magic number to another magic number here, and no test was added. If I'm right, the commit message mentions only 1 benchmark? This all together, feels like a big hack to me.
>
> Is there a better approach to this magic number?
>
> Slightly off topic, I also don't see the point of adding rdar tags to commit messages as they are meaningless to non-Apple folks.



Users:
  aemerson (Author)

https://reviews.llvm.org/rL360444