[PATCH] D61855: Simplify SymbolTable::add{Defined,Undefined,...} functions.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 13 07:57:14 PDT 2019


MaskRay added inline comments.


================
Comment at: lld/ELF/Symbols.h:368
 
-template <typename T, typename... ArgT>
-void replaceSymbol(Symbol *S, ArgT &&... Arg) {
+template <typename T> void replaceSymbol(Symbol *Sym, T *New) {
   using llvm::ELF::STT_TLS;
----------------
Agree with George. `T *New` -> `const T &New`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61855/new/

https://reviews.llvm.org/D61855





More information about the llvm-commits mailing list