[PATCH] D61258: AArch64: support binutils-like things on arm64_32.

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added reviewers: rengolin, kristof.beyls, olista01.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM. I've also added a few other reviewers, in case they have additional thoughts.



================
Comment at: llvm/tools/llvm-objdump/MachODump.cpp:2048
+    case MachO::CPU_SUBTYPE_ARM64_32_V8:
+      outs() << "    cputype CPU_TYPE_ARM64_32\n";
+      outs() << "    cpusubtype CPU_SUBTYPE_ARM64_V8\n";
----------------
Could we check for this in one of the tests?


================
Comment at: llvm/tools/llvm-objdump/MachODump.cpp:8137
+      switch (cpusubtype & ~MachO::CPU_SUBTYPE_MASK) {
+      case MachO::CPU_SUBTYPE_ARM64_32_V8:
+        outs() << "        V8";
----------------
Could we check for this in one of the tests?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61258/new/

https://reviews.llvm.org/D61258