[PATCH] D61688: [LLD][ELF] Full support for -n (--nmagic) and -N (--omagic) via -zcommon-page-size

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon May 13 00:45:33 PDT 2019


MaskRay added a comment.

LGTM



================
Comment at: ELF/Driver.cpp:1125
+    case OPT_nmagic:
+      Config->Static = true;
+      break;
----------------
IIRC @grimar said this should be moved to `case OPT_Bstatic:`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61688/new/

https://reviews.llvm.org/D61688





More information about the llvm-commits mailing list