[PATCH] D32530: [SVE][IR] Scalable Vector IR Type

Sander de Smalen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 10 09:45:12 PDT 2019


sdesmalen added a comment.

In D32530#1496945 <https://reviews.llvm.org/D32530#1496945>, @greened wrote:

> What's the status of this?  It seems like discussion has died down a bit.  I think Graham's idea to change from `<scalable 2 x float>` to `<vscale x 2 x float>` will make the IR more readable/understandable but it's not a show-stopper for me.


While I don't want to hold up this patch, a name change to the type will be difficult to get through once the type is in and the terminology has settled, so it may be worth getting it right from the start. Personally I think `<vscale x 16 x i8>` is more explicit (and therefore easier to understand for those new to the type) than `<scalable 16 x i8>`. And now that we all have a better understanding and clear definition of scalable types, I wonder if `<n x 16 x i8>` instead of `<vscale x 16 x i8>` is worth considering again, since it is much easier to read in tests.

Other than that, great to see this discussion on scalable types converging and so close to agreement!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D32530/new/

https://reviews.llvm.org/D32530





More information about the llvm-commits mailing list