[PATCH] D60260: Match types of accumulator and result for llvm.experimental.vector.reduce.fadd/fmul

[Nikita Popov via Phabricator via llvm-commits]

nikic requested changes to this revision.
nikic added a comment.
This revision now requires changes to proceed.

This looks good, but please also update existing tests that specify three types in the intrinstic name. Here's ones I found:

- test/CodeGen/X86/haddsub.ll
- test/CodeGen/X86/vector-reduce-fadd-fast.ll
- test/CodeGen/X86/vector-reduce-fadd.ll
- test/CodeGen/X86/vector-reduce-fmul-fast.ll
- test/CodeGen/X86/vector-reduce-fmul.ll

Looks like AArch64/Generic tests already use the (previously incorrect and now correct) two type form.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D60260/new/

https://reviews.llvm.org/D60260