[llvm] r360481 - Revert [DAGCombiner] Avoid creating large tokenfactors in visitTokenFactor

Jordan Rupprecht via llvm-commits llvm-commits at lists.llvm.org
Fri May 10 16:20:02 PDT 2019


Author: rupprecht
Date: Fri May 10 16:20:02 2019
New Revision: 360481

URL: http://llvm.org/viewvc/llvm-project?rev=360481&view=rev
Log:
Revert [DAGCombiner] Avoid creating large tokenfactors in visitTokenFactor

This reverts r360171 (git commit a9d6c32eafc645c55b07eb50698c428e14c0bffd). A repro showing the asan/msan failures is forthcoming.

Modified:
    llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp

Modified: llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp?rev=360481&r1=360480&r2=360481&view=diff
==============================================================================
--- llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (original)
+++ llvm/trunk/lib/CodeGen/SelectionDAG/DAGCombiner.cpp Fri May 10 16:20:02 2019
@@ -1792,9 +1792,8 @@ SDValue DAGCombiner::visitTokenFactor(SD
   TFs.push_back(N);
 
   // Iterate through token factors.  The TFs grows when new token factors are
-  // encountered. Limit number of nodes to inline, to avoid quadratic compile
-  // times.
-  for (unsigned i = 0; i < TFs.size() && Ops.size() <= 2048; ++i) {
+  // encountered.
+  for (unsigned i = 0; i < TFs.size(); ++i) {
     SDNode *TF = TFs[i];
 
     // Check each of the operands.




More information about the llvm-commits mailing list