[PATCH] D59065: Add ptrmask intrinsic

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri May 10 06:27:21 PDT 2019


fhahn updated this revision to Diff 199011.
fhahn marked 8 inline comments as done.
fhahn added a comment.

In D59065#1497227 <https://reviews.llvm.org/D59065#1497227>, @jdoerfert wrote:

> What happens if I use an integer type bigger than the native pointer width? Or smaller?


Initially I wanted to restrict the mask type to the native pointer width, but couldn't find how to do that in Intrinsics.td. On second thought, this might be more restrictive than necessary. I've adjusted the wording to make it clear that we zero-extend or truncate the mask if the bit width does not match the pointer size of the target. What do you think?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D59065/new/

https://reviews.llvm.org/D59065

Files:
  llvm/docs/LangRef.rst
  llvm/include/llvm/IR/Intrinsics.td
  llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
  llvm/test/CodeGen/AArch64/lower-ptrmask.ll
  llvm/test/CodeGen/X86/lower-ptrmask.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D59065.199011.patch
Type: text/x-patch
Size: 5477 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20190510/07e059c2/attachment.bin>


More information about the llvm-commits mailing list