[PATCH] D61718: [llvm-objdump] Print st_other

Fri May 10 04:35:48 PDT 2019

MaskRay marked 2 inline comments as done.
MaskRay added inline comments.

================
Comment at: llvm/test/tools/llvm-objdump/elf-symbol-visibility.s:1
+# REQUIRES: powerpc-registered-target
+# RUN: llvm-mc -filetype=obj -triple=powerpc64-pc-freebsd13.0 %s -o %t
----------------
jhenderson wrote:
> I think it's more normal to put a test with such a requirement inside a PowerPC/X86 subdirectory for llvm-objdump tests, but does this need to be assembly? Can it not be built with yaml2obj?
Changed to yaml2obj. Its `st_other` mapping is currently a bit clumsy to use. So I switched from ppc64 to mips... I may take a look how to improve that.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61718/new/

https://reviews.llvm.org/D61718