[PATCH] D61767: [llvm-elfabi] Emit ELF header and string table section

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 19:47:23 PDT 2019


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-elfabi/write-elf64be-ehdr.test:1
+# RUN: llvm-elfabi %s --output-target=elf64-big %t
+# RUN: llvm-readobj --file-headers %t | FileCheck %s
----------------
I should copy my comment to your earlier revision here. If at this early stage you don't care about big-endian, delete it, or at least make it realistic, e.g. `EM_PPC64`.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61767/new/

https://reviews.llvm.org/D61767





More information about the llvm-commits mailing list