[PATCH] D61696: [COFF] Simplify Chunk::writeTo and remove OutputSectionOff, NFC

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu May 9 15:00:14 PDT 2019


rnk marked an inline comment as done.
rnk added inline comments.


================
Comment at: lld/COFF/Chunks.h:126
   // The output section for this chunk.
   OutputSection *Out = nullptr;
 };
----------------
aganea wrote:
> Unrelated to this patch, but do you plan on converting 'Out' to an index as well?
Yes, I think it's necessary. It's tricky though because we create many OutputSections, and then throw away the empty ones, so using indices will necessary mean changing that or coming up with a new concept of "output section instance index". It's an index, but it goes into an `Instances` array, not the actual final image section index.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61696/new/

https://reviews.llvm.org/D61696





More information about the llvm-commits mailing list