[PATCH] D61560: [TargetLowering] Handle multi depth GEPs w/ inline asm constraints

[Nick Desaulniers via Phabricator via llvm-commits]

nickdesaulniers marked 3 inline comments as done.
nickdesaulniers added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/TargetLowering.cpp:3506
+        if (OpCode == ISD::ADD || OpCode == ISD::SUB) {
+          if ((C = dyn_cast<ConstantSDNode>(Op.getOperand(0))))
+            Op = Op.getOperand(1);
----------------
t.p.northover wrote:
> Subtraction is not commutative, so you need to be more careful here.
Good catch, thank you.  How's that look? Any thoughts on my SDLoc comment, above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61560/new/

https://reviews.llvm.org/D61560