[llvm] r360086 - Revert "Re-commit r357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)"

Thu May 9 00:46:40 PDT 2019

It's not large, but enough that we noticed, and the code that is
larger generated much nicer machine code with the patch applied so
we're hoping that we can get it back.

From: Jordan Rupprecht <rupprecht at google.com>
Date: Thu, May 9, 2019 at 1:42 AM
To: Hans Wennborg
Cc: llvm-commits

> Not yet, I'm dealing with a couple other regressions at the moment, but I'm still planning to look at it asap.
>
> Is a 32kb regression large?
>
> On Wed, May 8, 2019 at 6:35 AM Hans Wennborg <hans at chromium.org> wrote:
>>
>> FWIW we noticed a ~32 KB size regression on Chrome for Android when
>> rolling past your revert. Did you make any progress on figuring out
>> what's wrong with the lowering?
>>
>> On Tue, May 7, 2019 at 9:12 AM Hans Wennborg <hans at chromium.org> wrote:
>> >
>> > Sorry for the breakage.
>> >
>> > Please let me know when you have any details about how this broke things.
>> >
>> > On Mon, May 6, 2019 at 11:52 PM Jordan Rupprecht via llvm-commits
>> > <llvm-commits at lists.llvm.org> wrote:
>> > >
>> > > Author: rupprecht
>> > > Date: Mon May  6 14:55:05 2019
>> > > New Revision: 360086
>> > >
>> > > URL: http://llvm.org/viewvc/llvm-project?rev=360086&view=rev
>> > > Log:
>> > > Revert "Re-commit r357452: SimplifyCFG SinkCommonCodeFromPredecessors: Also sink function calls without used results (PR41259)"
>> > >
>> > > This reverts r357452 (git commit 21eb771dcb5c11d7500fa6ad551c97a921997f05).
>> > >
>> > > This was causing strange optimization-related test failures on an internal test. Will followup with more details offline.
>> > >
>> > > Modified:
>> > >     llvm/trunk/lib/Transforms/Utils/SimplifyCFG.cpp
>> > >     llvm/trunk/test/CodeGen/AArch64/max-jump-table.ll
>> > >     llvm/trunk/test/CodeGen/AArch64/min-jump-table.ll
>> > >     llvm/trunk/test/CodeGen/AArch64/win64-jumptable.ll
>> > >     llvm/trunk/test/CodeGen/ARM/cmpxchg-idioms.ll
>> > >     llvm/trunk/test/Transforms/SimplifyCFG/sink-common-code.ll